fix vsphere TLS client config overwrite #979
Conversation
kubermatic-bot
added
release-note
kubermatic-bot
added
the
size/XS
|
fix the release note :) . Also the ticket you are referring to is from KKP, you could create a ticket in MC so you can link to it and have it clean. |
| soapClient.DefaultTransport().TLSClientConfig = &tls.Config{ | ||
| RootCAs: util.CABundle, | ||
| } | ||
| soapClient.DefaultTransport().TLSClientConfig.RootCAs = util.CABundle |
There was a problem hiding this comment.
Are we sure soapClient.DefaultTransport().TLSClientConfig is never nil?
There was a problem hiding this comment.
It gets initialized in soap.NewClient():
c.t.TLSClientConfig = &tls.Config{InsecureSkipVerify: c.k}
kubermatic-bot
added
release-note-none
|
LGTM label has been added. Git tree hash: eecacd0c0c21664be0bf3ed83ff4a98808379fdc
|
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg, lsviben, WeirdMachine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
/cherry-pick release/v1.27 |
|
@WeirdMachine: new pull request created: #996 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Which issue(s) this PR fixes
Possible Fix for kubermatic/kubermatic#6859
Special notes for your reviewer:
Optional Release Note: