Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use semver versioning for default OperatingSystemProfiles #128

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Use semver versioning for default OperatingSystemProfiles #128

merged 1 commit into from
Jan 13, 2022

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Jan 13, 2022 •
edited
Loading

Signed-off-by: Waleed Malik ahmedwaleedmalik@gmail.com

What this PR does / why we need it:
Use semver versioning for default OperatingSystemProfiles

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@ahmedwaleedmalik
Use semver versioning for default OperatingSystemProfiles
34c2453 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jan 13, 2022
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 13, 2022
moadqassem
moadqassem approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 14d1a077757e18c1f6eea819bfc065869c7f7441

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,moadqassem]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit f039fa9 into kubermatic:master Jan 13, 2022
@ahmedwaleedmalik ahmedwaleedmalik deleted the use-semver-osp branch January 13, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadqassem moadqassem moadqassem approved these changes

Assignees

@moadqassem moadqassem

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmedwaleedmalik @kubermatic-bot @moadqassem