Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Generate from openapi release-1.24 #126

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jun 5, 2022

No description provided.

Signed-off-by: Kubernetes Prow Robot <k8s.ci.robot@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2022
@k8s-ci-robot k8s-ci-robot requested a review from ityuhui June 5, 2022 18:16
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 5, 2022
@ityuhui
Copy link
Member

ityuhui commented Jun 6, 2022

The code change looks good to me.
But this PR didn't trigger the build and test action.

I will close and reopen this PR to try to trigger the build and test.

Refer to PRs created don't trigger other actions

@ityuhui ityuhui closed this Jun 6, 2022
@ityuhui ityuhui reopened this Jun 6, 2022
@ityuhui
Copy link
Member

ityuhui commented Jun 6, 2022

There is a build error in the example:

cd examples/
  make
  shell: /usr/bin/bash -e {0}
cd create_pod; make
make[1]: Entering directory '/home/runner/work/c/c/examples/create_pod'
gcc main.c -g -I../../kubernetes/include -I../../kubernetes/model -I../../kubernetes/api -I../../kubernetes/config -L../../kubernetes/build -lkubernetes -lyaml -lwebsockets -L/usr/local/lib -o create_pod_bin
main.c: In function ‘create_a_pod’:
main.c:26:[3](https://github.com/kubernetes-client/c/runs/6748985393?check_suite_focus=true#step:8:3)0: error: ‘kubernetes_v1_container_IMAGEPULLPOLICY_IfNotPresent’ undeclared (first use in this function)
   26 |     con->image_pull_policy = kubernetes_v1_container_IMAGEPULLPOLICY_IfNotPresent;
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
main.c:26:30: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:[7](https://github.com/kubernetes-client/c/runs/6748985393?check_suite_focus=true#step:8:8): all] Error 1
make[1]: Leaving directory '/home/runner/work/c/c/examples/create_pod'
make: *** [Makefile:2: all] Error 2
Error: Process completed with exit code 2.

The type of imagePullPolicy changes from enum to string. We can fix this issue by changing the example code from

con->image_pull_policy = kubernetes_v1_container_IMAGEPULLPOLICY_IfNotPresent;

to

con->image_pull_policy = strdup("IfNotPresent");

@brendandburns
Copy link
Contributor

I will add a commit to fix these.

@brendandburns
Copy link
Contributor

@ityuhui commit added, please take another look.

@ityuhui
Copy link
Member

ityuhui commented Jun 8, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: github-actions[bot], ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0e1055b into master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants