Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conan support is added #230

Merged
merged 4 commits into from
Apr 28, 2024
Merged

Conan support is added #230

merged 4 commits into from
Apr 28, 2024

Conversation

ydcpp
Copy link
Contributor

@ydcpp ydcpp commented Apr 21, 2024

Added conanfile.py and conan.md files to build and use project as conan package.

Copy link

linux-foundation-easycla bot commented Apr 21, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 21, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ydcpp!

It looks like this is your first PR to kubernetes-client/c 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/c has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 21, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 21, 2024
docs/conan.md Outdated Show resolved Hide resolved
kubernetes/conanfile.py Outdated Show resolved Hide resolved
kubernetes/conanfile.py Outdated Show resolved Hide resolved
@ityuhui ityuhui linked an issue Apr 22, 2024 that may be closed by this pull request
@ydcpp
Copy link
Contributor Author

ydcpp commented Apr 22, 2024

there was a small problem with typedef naming in kubernetes/websocket/wsclient.h file which causes c++ compilers to error when including that header. I also added that change to this PR since conan is both for c and c++ users.

@ydcpp ydcpp requested a review from ityuhui April 22, 2024 09:11
kubernetes/conanfile.py Outdated Show resolved Hide resolved
@ydcpp ydcpp requested a review from ityuhui April 25, 2024 15:14
kubernetes/conanfile.py Outdated Show resolved Hide resolved
kubernetes/conanfile.py Outdated Show resolved Hide resolved
@ydcpp ydcpp requested a review from ityuhui April 27, 2024 10:50
@ityuhui
Copy link
Member

ityuhui commented Apr 28, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ityuhui, ydcpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit fbe4574 into kubernetes-client:master Apr 28, 2024
8 checks passed
@ityuhui
Copy link
Member

ityuhui commented Apr 28, 2024

Thanks to @ydcpp for the contribution! The c client library is now supported by conan. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conan support
3 participants