Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 2 useful PRs and other changes from OpenAPITools/openapi-generator repo #7

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

ityuhui
Copy link
Member

@ityuhui ityuhui commented Apr 1, 2020

To implement the configuration for kubernetes-client/c, merge 2 PRs from OpenAPITools/openapi-generator repo:

  1. Support SSL client authentication for the c client (#5719)
    [C][Client] Support SSL client authentication for the c client OpenAPITools/openapi-generator#5719

  2. Fix base64 decode funtion (#5642)
    [C] fix decode function OpenAPITools/openapi-generator#5642

/cc @brendandburns

1. Support SSL client authentication for the c client (#5719)

2. Fix base64 decode funtion (#5642)
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2020
@brendandburns
Copy link
Contributor

This change looks good to me.

Is this a manual patch? Or did you re-run code generation?

@ityuhui
Copy link
Member Author

ityuhui commented Apr 2, 2020

Hi @brendandburns

Yes, this is a manual patch.

We do not need re-run code generation because there is no difference between manual patch and code generation for the files apiClient.h and apiClient.c.

For others model or api files generated by openapi-generator, there is also no important changes.

But I can re-run code generation too, it does not need big effort. which solution do you prefer ?

@brendandburns
Copy link
Contributor

I'd prefer that we re-run the code generation, I think it is a good practice to never hand-edit the generated files.

Thanks!

@ityuhui
Copy link
Member Author

ityuhui commented Apr 2, 2020

Sure. I will do it.

And c/kubernetes/README.md which is updated in the PR #5 will not be changed when re-generating.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 2, 2020
@ityuhui
Copy link
Member Author

ityuhui commented Apr 2, 2020

Hi @brendandburns

The code generation is re-run (both build and examples test successfully) and new code change is pushed here.
Could you please review the latest change change ?

@ityuhui ityuhui changed the title Apply 2 useful patches from OpenAPITools/openapi-generator repo Apply 2 useful patches and other changes from OpenAPITools/openapi-generator repo Apr 2, 2020
@ityuhui ityuhui changed the title Apply 2 useful patches and other changes from OpenAPITools/openapi-generator repo Merge 2 useful PRs and other changes from OpenAPITools/openapi-generator repo Apr 2, 2020
@brendandburns
Copy link
Contributor

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,ityuhui]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d9ae510 into kubernetes-client:master Apr 2, 2020
@ityuhui ityuhui deleted the yhworking branch April 3, 2020 02:11
@minerba minerba mentioned this pull request Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants