chore: add StandardOutput timeout

kubernetes-client · Apr 18, 2023 · 8571591 · 8571591
1 parent 9eecb4a
commit 8571591
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/src/KubernetesClient/KubernetesClientConfiguration.ConfigFile.cs b/src/KubernetesClient/KubernetesClientConfiguration.ConfigFile.cs
@@ -588,14 +588,23 @@ public static ExecCredentialResponse ExecuteExternalCommand(ExternalExecution co
                 throw new KubeConfigException($"external exec failed due to: {stderr}");
             }
 
-            var stdout = process.StandardOutput.ReadToEnd();
-
             // Wait for a maximum of 5 seconds, if a response takes longer probably something went wrong...
-            process.WaitForExit(5);
+            var stdOutTask = process.StandardOutput.ReadToEndAsync();
+
+            string stdOut;
+
+            if (stdOutTask.Wait(TimeSpan.FromSeconds(5)))
+            {
+                stdOut = stdOutTask.Result;
+            }
+            else
+            {
+                throw new KubeConfigException("external exec failed due to timeout");
+            }
 
             try
             {
-                var responseObject = KubernetesJson.Deserialize<ExecCredentialResponse>(stdout);
+                var responseObject = KubernetesJson.Deserialize<ExecCredentialResponse>(stdOut);
                 if (responseObject == null || responseObject.ApiVersion != config.ApiVersion)
                 {
                     throw new KubeConfigException(