Added msbuild build of project in buildtest action #1022
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
what is the output of |
|
@tg123 I have retested the pipeline and it seems fine. |
|
well this is really weird to me /LGTM |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: m3nax, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| # Test code gen for visual studio compatibility >> https://github.com/kubernetes-client/csharp/pull/1008 | ||
| codgen: | ||
| runs-on: windows-latest | ||
| name: MSBuild build |
There was a problem hiding this comment.
Is there some wrong with the dotnet build
There was a problem hiding this comment.
Yes, there is a weird bug:
- with msbuild and the Microsoft.CodeAnalysis.CSharp Version = 4.3.0 the project does not compile (https://github.com/kubernetes-client/csharp/actions/runs/3087969401/jobs/4993905209#step:6: 41) and prevented it from being used with Visual Studio.
- with dotnet build the project compiled correctly.
A few days ago the brach master had all actions completed successfully but did not compile when opened with visual studio.
If you want to check, set the Microsoft.CodeAnalysis.CSharp package version to 4.3.0, clean the project and compile it with visual studio.
Close #1009