Refactor LibKubernetesGenerator code structure #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1546 +/- ##
=========================================
Coverage ? 61.46%
=========================================
Files ? 103
Lines ? 3065
Branches ? 637
=========================================
Hits ? 1884
Misses ? 1181
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the code structure of the LibKubernetesGenerator project.
Why
the old template Nustache is inactive and did not recieve any update in last 5 yr.
The syntax of Nustache is not friendly to developers:
elseNew Template Engine
https://github.com/scriban/scriban/
The scriban templating engine was chosen over other options due to its unique features that make it suitable for code generation. One of these features is the embed mode, which is specifically designed for this purpose.
Furthermore, scriban offers a rich syntax that meets the requirements of the current SDK build. This means it provides a wide range of functionalities that can handle complex templating tasks, making it an excellent choice for this use case.