Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy local file to pod using tar #962

Merged
merged 4 commits into from
Jul 27, 2022

Conversation

lazarkrstic
Copy link
Contributor

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 21, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: lazarkrstic / name: Lazar Krstić (86b15a5)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 21, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @lazarkrstic!

It looks like this is your first PR to kubernetes-client/csharp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/csharp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 21, 2022
Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

I will make inner websocket chunked

examples/cp/Cp.cs Outdated Show resolved Hide resolved
examples/cp/Cp.cs Outdated Show resolved Hide resolved
examples/cp/demo.txt Outdated Show resolved Hide resolved
Co-authored-by: Boshi Lian <farmer1992@gmail.com>
lazarkrstic added a commit to lazarkrstic/csharp that referenced this pull request Jul 21, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 21, 2022
@lazarkrstic lazarkrstic requested a review from tg123 July 21, 2022 22:36
Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 21, 2022
@lazarkrstic
Copy link
Contributor Author

Can you remove label invalid-commit-message , I amended my privious git message

@tg123
Copy link
Member

tg123 commented Jul 22, 2022

do not put # in message, just remove it and push -f

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Jul 22, 2022
Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lazarkrstic, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d59f4da into kubernetes-client:master Jul 27, 2022
@cody-malcolm
Copy link

@lazarkrstic Thanks for doing this. When I use this example, the file is copied to the pod successfully, but then the thread blocks on the error checking starting at line 96...specifically being blocked by streamReader.EndOfStream. I have tried various other ways to perform the same check (such as ReadLine, Read, or stdError.Length) and they all block. If I remove the error check entirely, it will block in Kubernetes.Exec.cs at await errorReader.ReadToEndAsync().ConfigureAwait(false);. Do you know why this might be happening or what can be done to fix it? I'm out of ideas to fix it. Thanks in advance.

@tg123
Copy link
Member

tg123 commented Sep 14, 2022

@cody-malcolm what is your base image?

only ubuntu' tar passed the test

see comment here

// Image = "busybox", // TODO not work with busybox

@cody-malcolm
Copy link

cody-malcolm commented Sep 14, 2022

@tg123 We are using node:16.15.0-alpine base image. Based on Alpine Linux.

Edit: After some digging, I discovered this uses busybox, and the implementation doesn't work with the busybox version of tar. So that explains the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants