Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python generator is auto-generating wrong links in README #133

Closed
palnabarun opened this issue Oct 24, 2019 · 3 comments · Fixed by #134
Closed

Python generator is auto-generating wrong links in README #133

palnabarun opened this issue Oct 24, 2019 · 3 comments · Fixed by #134
Assignees
@palnabarun
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@palnabarun
Copy link
Member

There are some links that are being wrongly generated in the README, specifically the link to install the kubernetes python client package using the git link.

Generated link: pip install git+https://github.com/kubernetes-kubernetes.client/python.git
Expected link: pip install git+https://github.com/kubernetes-client/python.git

References:
@palnabarun
Copy link
Member Author

/assign

@palnabarun
Copy link
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 24, 2019
@palnabarun palnabarun mentioned this issue Oct 24, 2019
Closed
palnabarun added a commit to palnabarun/gen that referenced this issue Oct 24, 2019
@palnabarun
Updates the python generator
1c82c0a 
Fixes kubernetes-client#133
@palnabarun
Copy link
Member Author

/cc @roycaihw

@palnabarun palnabarun mentioned this issue Oct 24, 2019
Merged
@palnabarun palnabarun mentioned this issue Nov 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palnabarun palnabarun

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes the wrong link auto-generation in the python generator palnabarun/gen
2 participants
@palnabarun @k8s-ci-robot