Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preprocess_spec.py to handle if 'name' doesn't exist. #250

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

brendandburns
Copy link
Contributor

--- Downloading and pre-processing OpenAPI spec
/usr/local/lib/python3.9/dist-packages/urllib3/connectionpool.py:842: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
  warnings.warn((
Traceback (most recent call last):
  File "//preprocess_spec.py", line 543, in <module>
    sys.exit(main())
  File "//preprocess_spec.py", line 537, in main
    out_spec = process_swagger(in_spec, args.client_language, crd_mode)
  File "//preprocess_spec.py", line 196, in process_swagger
    apply_func_to_spec_operations(spec, strip_delete_collection_operation_watch_params)
  File "//preprocess_spec.py", line 71, in apply_func_to_spec_operations
    if func(v[op], v, *params):
  File "//preprocess_spec.py", line 107, in strip_delete_collection_operation_watch_params
    paramName = op['parameters'][i]['name']
KeyError: 'name'

https://github.com/kubernetes-client/javascript/actions/runs/6214469452/job/16866433360

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2023
@brendandburns
Copy link
Contributor Author

@yliaog

@yliaog
Copy link
Contributor

yliaog commented Sep 18, 2023

what is the recent change that caused this? just curious.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0ef2cec into master Sep 18, 2023
2 checks passed
@brendandburns
Copy link
Contributor Author

@yliaog this was me trying to run this on the Kubernetes 1.28 openapi schema. I haven't dug into the schema to figure out where/how the problem was introduced.

@yliaog
Copy link
Contributor

yliaog commented Sep 19, 2023

Got it. Thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants