-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with kubernetes-client dependency on time on Hackage #77
Comments
This happened due to generating bounds with stack while uploading to hackage. So, if you run As for updating hackage, there was a recent merge, so I was going to upload another version anyway. Maybe this time I can just not generate upper bounds while uploading. WDYT @jonschoning @guoshimin? |
I think it may make more sense to have the bounds be the same as the package.yaml. If there's a need to include an upper bound, lets include that in package.yaml as well. Personally I tend to adjust upper bounds manually so I don't have much experience with how |
Using We could just put the upper bounds manually, but I am not sure how would we choose a good upper bound for a given dependency. How do you do it? Since, I don't have a way, I just remove all upper bounds until something breaks. When I face such problem, I can either fix the code to work with both version or I can just put an upper bound depending on effort of it. |
@magthe I have published a new revision of |
One way to deal with it in the future could be to
|
@jonschoning Is it ok if we do it as @magthe says? |
sounds good to me
…On Mon, Sep 14, 2020, 1:10 PM Akshay Mankar ***@***.***> wrote:
@jonschoning <https://github.com/jonschoning> Is it ok if we do it as
@magthe <https://github.com/magthe> says?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#77 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABBPXZOFXOJ6NVCCWJ72UTSFZMDBANCNFSM4Q63FBGQ>
.
|
I also published the the latest version. I will close this issue now. /close |
@akshaymankar: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm not sure what's happened, but kubernetes-client 0.2.0.0 available on Hackage has a dependency on
time ==1.8.*
, which makes it difficult to build with GHC 8.8 (8.8.4 hastime 1.9.3
). I'm not completely sure why the generated Cabal file has that version bound though, because thepackage.yaml
clearly states a dependency ontime >=1.8
.I just ran
hpack
(version 0.34.2) manually on thepackage.yaml
and the generated Cabal file is correct, i.e. a dependency ontime >=1.8
. So basically I'm confused about this...Would someone please take pity on us Hackage users and adjust the dependency in the Cabal file?
The text was updated successfully, but these errors were encountered: