Expand HOME detection on Windows.

[brendandburns]

Further fixes for #386

This emulates the kubeconfig code found here:

https://github.com/kubernetes/client-go/blob/master/util/homedir/homedir.go

@yu-shiba

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yu-shiba]

I also thought about the same thing.

I adopted the #387 approach because of emphasis on compatibility with existing assets,

1. io.kubernetes.client.util.KubeConfig#ENV_HOME is a public member and can not make drastic changes
2. The same fault occurs when referencing io.kubernetes.client.util.KubeConfig#ENV_HOME with other code
3. Respond with minimal change

Is there a problem with the above?

[brendandburns]

I don't think anyone is using ENV_HOME and I prefer to behave the same way as kubectl/client-go

So I think I prefer this fix...

Thanks!

[yu-shiba]

I agree with you.
#387 also wanted to do like this #390.

The code of #387 is not beautiful though what I say it myself...

[brendandburns]

@yu-shiba if you have time, please take a look and review this code.

If it looks good, you can reply /lgtm

And then this code can merge.

Thanks!

[yu-shiba]

/lgtm

[k8s-ci-robot]

@yu-shiba: changing LGTM is restricted to assignees, and only kubernetes-client/java repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yu-shiba]

@brendandburns Is it not good?
Feeling insufficient authority.

[yu-shiba]

/lgtm

[k8s-ci-robot]

@yu-shiba: changing LGTM is restricted to assignees, and only kubernetes-client/java repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[brendandburns]

self-lgtm on lgtm from @yu-shiba