Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install from git via npm #76

Closed
burn2delete opened this issue Aug 6, 2018 · 0 comments
Closed

install from git via npm #76

burn2delete opened this issue Aug 6, 2018 · 0 comments

Comments

@burn2delete
Copy link
Contributor

#65 has instructions for a local install from git, however this is inconvenient for CI/CD processes as we need to download and build a dependency which results in longer build times, and increased complexity.

NPM supports installs from github via npm install kubernetes-client/javascript, however the current directory structure prevents this from working.

To solve these issues:

  • flatten the project structure so package.json is in the root of the repo
  • stick to one project per repo, if there is a jquery client in the future it should have it's own repo
edvald added a commit to garden-io/javascript that referenced this issue Oct 30, 2018
@edvald
refactor: move node-client package to repo root
8c7009e 
This allows installing directly from git via npm.
Closes kubernetes-client#76
@edvald edvald mentioned this issue Oct 30, 2018
Merged
edvald added a commit to garden-io/javascript that referenced this issue Oct 31, 2018
@edvald
refactor: move node-client package to repo root
8d84b48 
This allows installing directly from git via npm.
Closes kubernetes-client#76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@burn2delete