ci: add release workflow for 1.x #1444
Conversation
k8s-ci-robot
added
cncf-cla: yes
.github/workflows/release.yml
Outdated
| required: true | ||
| default: false | ||
| description: Dry run, will not push branches or upload the artifacts. | ||
| pre_release: |
There was a problem hiding this comment.
For now, this needs to always be true or we will accidentally replace the "production" release on npm with the 1.x release. We can decide when we want to do that, but for now at least default to true, and possibly force it to true.
There was a problem hiding this comment.
Good point. I think the condition I've added will always publish with the --next flag and never without the --next flag.
There was a problem hiding this comment.
I'd be a lot more comfortable if we just removed this for now. Is there a reason to leave it in?
There was a problem hiding this comment.
Good point, I've tried to make the changes as small as possible but you are very right, removing the risk completely is way better.
I've changed it to remove the input and all references/steps we do not want to tigger.
|
One comment releated to the |
mstruebing
force-pushed
the
mstruebing/ci/add-release-workflow-for-1.x
branch
from
39cc5f1
to
4522bbf
Compare
k8s-ci-robot
added
do-not-merge/invalid-commit-message
I wanted to publish a new release for kubernetes-client#1398 but it seems like the workflow is only available on the master branch thus it means it can not get executed in the release-1.x branch. Porting over the file and use latest node LTS in the setup-node action.
mstruebing
force-pushed
the
mstruebing/ci/add-release-workflow-for-1.x
branch
from
4522bbf
to
84d5280
Compare
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
I wanted to publish a new release for #1398 but it seems like the workflow is only available on the master branch thus it means it can not get executed in the release-1.x branch. Porting over the file and use latest node LTS in the setup-node action.