Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate client for Kubernetes 1.20.0, Rev package version to 0.14.0 #585

Merged
merged 3 commits into from
Feb 16, 2021

Conversation

brendandburns
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 12, 2021
@drubin
Copy link
Contributor

drubin commented Feb 12, 2021

@brendandburns the tests seem to fail but not 100% sure why. So something seems funky.

in general, the changes seem great but I would suggest splitting the manual changes and auto generated changes into 2 commits.

@drubin
Copy link
Contributor

drubin commented Feb 12, 2021

/assign @brendandburns

@brendandburns
Copy link
Contributor Author

@drubin thanks for review. I forgot to include some new files (forgot git add) so it worked locally, but obviously not remotely (thank goodness for CI/CD :)

Anyway, it's fixed, and I split out the manual changes into their own commit. Please take another look.

Thanks!

@drubin
Copy link
Contributor

drubin commented Feb 16, 2021

/lgtm

Thanks for the quick turnaround and for improving the commits.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7514882 into kubernetes-client:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants