Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Merging configs with missing fields #163

Merged
merged 2 commits into from
Sep 24, 2019
Merged

Merging configs with missing fields #163

merged 2 commits into from
Sep 24, 2019

Conversation

goddenrich
Copy link
Contributor

addresses issue #162

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 23, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2019
@goddenrich
Copy link
Contributor Author

/assign @roycaihw

@goddenrich
Copy link
Contributor Author

I think the failing tests are unrelated to this change

@roycaihw
Copy link
Member

test failure tracked in kubernetes-client/python#963

/cc @tomplus

Copy link
Member

@tomplus tomplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@roycaihw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goddenrich, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9f73cc6 into kubernetes-client:master Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants