Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent timeout of WSClient.update #1963

Closed
t-yrka opened this issue Dec 6, 2022 · 1 comment · Fixed by #1976
Closed

Inconsistent timeout of WSClient.update #1963

t-yrka opened this issue Dec 6, 2022 · 1 comment · Fixed by #1976
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@t-yrka
Copy link
Contributor

t-yrka commented Dec 6, 2022

What happened (please include outputs or screenshots):

https://github.com/kubernetes-client/python/blob/master/kubernetes/base/stream/ws_client.py#L182-L189
The timeout behavior of the update method is inconsistent.
Function select.select interprets timeout as floating-point seconds where the polling object (poll method) uses milliseconds.

What you expected to happen:

The timeout unit is the same in all cases.

How to reproduce it (as minimally and precisely as possible):

Exec update with select and poll.

Anything else we need to know?:

Environment:

  • Kubernetes version (kubectl version):
  • OS (e.g., MacOS 10.13.6):
  • Python version (python --version) 3.10.8
  • Python client version (pip list | grep kubernetes) 25.3.0
@t-yrka t-yrka added the kind/bug Categorizes issue or PR as related to a bug. label Dec 6, 2022
@roycaihw
Copy link
Member

@t-yrka would you like to send a PR? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants