We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What happened (please include outputs or screenshots):
https://github.com/kubernetes-client/python/blob/master/kubernetes/base/stream/ws_client.py#L182-L189 The timeout behavior of the update method is inconsistent. Function select.select interprets timeout as floating-point seconds where the polling object (poll method) uses milliseconds.
update
select.select
poll
What you expected to happen:
The timeout unit is the same in all cases.
How to reproduce it (as minimally and precisely as possible):
Exec update with select and poll.
select
Anything else we need to know?:
Environment:
kubectl version
python --version
3.10.8
pip list | grep kubernetes
25.3.0
The text was updated successfully, but these errors were encountered:
@t-yrka would you like to send a PR? Thanks
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
What happened (please include outputs or screenshots):
https://github.com/kubernetes-client/python/blob/master/kubernetes/base/stream/ws_client.py#L182-L189
The timeout behavior of the
update
method is inconsistent.Function
select.select
interprets timeout as floating-point seconds where the polling object (poll
method) uses milliseconds.What you expected to happen:
The timeout unit is the same in all cases.
How to reproduce it (as minimally and precisely as possible):
Exec
update
withselect
andpoll
.Anything else we need to know?:
Environment:
kubectl version
):python --version
)3.10.8
pip list | grep kubernetes
)25.3.0
The text was updated successfully, but these errors were encountered: