Add RBAC rules for CSI csidrivers CRD #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/assign @msau42 |
msau42
reviewed
Jan 9, 2019
deploy/kubernetes/rbac.yaml
Outdated
| @@ -24,6 +24,9 @@ rules: | |||
| - apiGroups: [""] | |||
There was a problem hiding this comment.
I think the events and nodes rules are not needed. Also, can you change the name of the cluster role to something like "cluster-driver-registrar-role"
There was a problem hiding this comment.
Updated PR. Removed nodes and events RBAC rules and renamed clusterrole.
|
Fixes #3 |
k8s-ci-robot
added
size/S
|
Thanks so much! This lgtm. Please squash |
sarjeet2013
force-pushed
the
rbac_rules_csidrivers
branch
from
ab1a651
to
ff95ba0
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, sarjeet2013 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the RBAC rules for csidrivers crd which was missing from rbac.yaml
Tested without the rules and get errors in creating csidrivers CRD objects.
E0109 18:08:45.418972 1 k8s_register.go:118] Failed to create CSIDriver object: csidrivers.csi.storage.k8s.io is forbidden: User "system:serviceaccount:mapr-csi:csi-provisioner-sa" cannot create resource "csidrivers" in API group "csi.storage.k8s.io" at the cluster scope
With fix, Able to get the correct CRD object being created for csidrivers.