CRD + RBAC fixes #36
CRD + RBAC fixes #36
Conversation
This shouldn't be done by us in the first place, and inhibits dependency upgrades beyond k8s 1.12. Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pohly If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Would not registering the CRD be considered a breaking change? That may not be something we should put into a patch release. |
|
I don't know whether people relied on this alpha-level feature in v1.0.1. Personally I consider it a bug, and thus fixing it in a patch release would be okay. You can also create a release-1.1 branch off the v1.0.1 tag and I'll create a PR against that branch, if you prefer to do a v1.1.0 with this fix instead of v1.0.2. I'm fine with that, too. |
|
/hold We discussed this on Monday and didn't come to a conclusion whether this needs to be fixed at all and if so, in which release (v1.0.1 or v1.1.0) and with or without removal of the CRD installation. On hold for now until we know whether this really affects anyone. |
k8s-ci-robot
added
the
do-not-merge/hold
|
cluster-driver-registrar is deprecated, no need for this PR anymore |
The RBAC file in v1.0.1 was incorrect and the code shouldn't register CRDs. All of that has already been fixed on the master branch, but not the release-1.0 branch.
Fixes: #3
/assign @msau42