Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.16 deployment doesn't work on older clusters #118

Closed
msau42 opened this issue Nov 5, 2019 · 7 comments
Closed

1.16 deployment doesn't work on older clusters #118

msau42 opened this issue Nov 5, 2019 · 7 comments
Assignees
@ggriffiths
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.

Comments

@msau42
Copy link
Collaborator

msau42 commented Nov 5, 2019

New CI jobs testing 1.16 deployment on older K8s versions is failing because of the dependency on the new volumeLifecycleModes:

https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-csi-1-16-on-kubernetes-1-15/1191821907750555651

error: error validating "STDIN": error validating data: ValidationError(CSIDriver.spec): unknown field "volumeLifecycleModes" in io.k8s.api.storage.v1beta1.CSIDriverSpec; if you choose to ignore these errors, turn validation off with --validate=false

I think this is working as intended since the 1.16 deployment depends on new APIs added in K8s 1.16. I think that means we should remove any CI jobs that test newer deployments against older versions. @pohly wdyt?

/kind failing-test
@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Nov 5, 2019
@pohly
Copy link
Contributor

pohly commented Nov 6, 2019

I think that means we should remove any CI jobs that test newer deployments against older versions.

Agreed. Those jobs would have been useful if a) they worked (obviously... 😁 ) and b) if we wanted to support running newer sidecars on older Kubernetes releases. With the interpretation of "recommended Kubernetes version" as "this is what we released for, don't run on anything older even if it would work", we no longer do the latter.

@BenTheElder
Copy link

will this mean actually dropping support for older versions, or just for the deployment?
if I use a custom deployment can I support older kubernetes versions?

@msau42
Copy link
Collaborator Author

msau42 commented Dec 6, 2019

Our 1.16 version of the deployment specs uses a new api field introduced in 1.16.

So if you want to deploy on an older cluster, the deployment spec should not use the new field (and therefore not support the new 1.16 functionality)

@ggriffiths
Copy link
Member

/assign ggriffiths

@ggriffiths
Copy link
Member

I think this was fixed via kubernetes/test-infra#15685 @msau42

@msau42
Copy link
Collaborator Author

msau42 commented Mar 4, 2020

/close
Thanks!

@k8s-ci-robot
Copy link
Contributor

@msau42: Closing this issue.

In response to this:

/close
Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fengzixu pushed a commit to fengzixu/csi-driver-host-path that referenced this issue Dec 31, 2020
@k8s-ci-robot
Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
3b6d17b 
cloud build: double the timeout, now 1 hour
fengzixu added a commit to fengzixu/csi-driver-host-path that referenced this issue Jan 4, 2021
@fengzixu
Squashed 'release-tools/' changes from c6a88c6..2bb7525
b80bed3 
2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master
3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
4ab8b15 use the tag to replace commit of csi-test
5d74e45 change the csi-test import path to v4
7dcd0a9 upgrade csi-test to v4.0.2
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: 2bb7525
fengzixu added a commit to fengzixu/csi-driver-host-path that referenced this issue Jan 4, 2021
@fengzixu
Squashed 'release-tools/' changes from c6a88c6..2bb7525
7e752df 
2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master
3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
4ab8b15 use the tag to replace commit of csi-test
5d74e45 change the csi-test import path to v4
7dcd0a9 upgrade csi-test to v4.0.2
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: 2bb7525
kvaps added a commit to kvaps/csi-driver-host-path that referenced this issue Jan 19, 2021
@kvaps
Squashed 'release-tools/' changes from c6a88c6..ece0f50
5961195 
ece0f50 check namespace for snapshot-controller
3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: ece0f50
kvaps added a commit to kvaps/csi-driver-host-path that referenced this issue Jan 25, 2021
@kvaps
Squashed 'release-tools/' changes from c6a88c6..fe1f2848
dddc2c4 
fe1f2848 Merge pull request kubernetes-csi#121 from kvaps/namespace-check
8fdf0f78 Merge pull request kubernetes-csi#128 from fengzixu/master
1c94220d fix: fix a bug of csi-sanity
a4c41e6a Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate
ece0f50 check namespace for snapshot-controller
dbd89672 verify-boilerplate.sh: fix path to script
9289fd16 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks
ad29307f Make the spelling and boilerplate checks optional
5f06d024 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests
48186eba Fix spelling and boilerplate errors
71690aff Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests
981be3fe Adding spelling and boilerplate checks.
2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master
3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
4ab8b15 use the tag to replace commit of csi-test
5d74e45 change the csi-test import path to v4
7dcd0a9 upgrade csi-test to v4.0.2
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: fe1f284817af983ce0f0329fa3a0d55f577aa727
pohly added a commit to pohly/csi-driver-host-path that referenced this issue Mar 15, 2021
@pohly
Squashed 'release-tools/' changes from 7bc70e52..00bc64a9
3c0f612 
00bc64a9 remove travis.yml, Go 1.16
REVERT: 7bc70e52 Merge pull request kubernetes-csi#129 from pohly/squash-documentation
REVERT: e0b02e72 README.md: document usage of --squash
REVERT: 316cb957 Merge pull request kubernetes-csi#132 from yiyang5055/bugfix/boilerplate
REVERT: 26e2ab10 fix: default boilerplate path
REVERT: 1add8c18 Merge pull request kubernetes-csi#133 from pohly/kubernetes-1.20-tag
REVERT: 3e811d6c prow.sh: fix "on-master" prow jobs
REVERT: 1d60e779 Merge pull request kubernetes-csi#131 from pohly/kubernetes-1.20-tag
REVERT: 9f104590 prow.sh: support building Kubernetes for a specific version
REVERT: fe1f2848 Merge pull request kubernetes-csi#121 from kvaps/namespace-check
REVERT: 8fdf0f78 Merge pull request kubernetes-csi#128 from fengzixu/master
REVERT: 1c94220d fix: fix a bug of csi-sanity
REVERT: a4c41e6a Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate
REVERT: ece0f50 check namespace for snapshot-controller
REVERT: dbd89672 verify-boilerplate.sh: fix path to script
REVERT: 9289fd16 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks
REVERT: ad29307f Make the spelling and boilerplate checks optional
REVERT: 5f06d024 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests
REVERT: 48186eba Fix spelling and boilerplate errors
REVERT: 71690aff Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests
REVERT: 981be3fe Adding spelling and boilerplate checks.
REVERT: 2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master
REVERT: 3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
REVERT: 9318c6c cloud build: double the timeout, now 1 hour
REVERT: 4ab8b15 use the tag to replace commit of csi-test
REVERT: 5d74e45 change the csi-test import path to v4
REVERT: 7dcd0a9 upgrade csi-test to v4.0.2
REVERT: 86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
REVERT: c3a9662 allow export image name and registry name
REVERT: c6a88c6 Merge pull request kubernetes-csi#113 from xing-yang/install_snapshot_controller
REVERT: 45ec4c6 Fix the install of snapshot CRDs and controller
REVERT: 5d874cc Merge pull request kubernetes-csi#112 from xing-yang/cleanup
REVERT: 79bbca7 Cleanup
REVERT: d437673 Merge pull request kubernetes-csi#111 from xing-yang/update_snapshot_v1_rc
REVERT: 57718f8 Update snapshot CRD version
REVERT: 4aff857 Merge pull request kubernetes-csi#109 from pohly/alpha-test-defaults
REVERT: 0427289 Merge pull request kubernetes-csi#110 from pohly/kind-0.9-bazel-build-workaround
REVERT: 9a370ab prow.sh: work around "kind build node-image" failure
REVERT: 522361e prow.sh: only run alpha tests for latest Kubernetes release
REVERT: 22c0395 Merge pull request kubernetes-csi#108 from bnrjee/master
REVERT: b5b447b Add go ldflags using LDFLAGS at the time of compilation
REVERT: 16f4afb Merge pull request kubernetes-csi#107 from pohly/kind-update

git-subtree-dir: release-tools
git-subtree-split: 00bc64a9b7c2585676b1da301a7acae8797229a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggriffiths ggriffiths

Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pohly @BenTheElder @ggriffiths @k8s-ci-robot @msau42