Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostpath driver fails to delete volumesnapshotcontent whose DeletionPolicy is patched to Delete #178

Closed
ashish-amarnath opened this issue Apr 28, 2020 · 6 comments

Comments

@ashish-amarnath
Copy link
Contributor

What happened:
A patched volumesnapshotcontent object does not get deleted.

These are the steps that I followed:

  1. Create a volumesnapshot using a volumesnapshotclass with DeletionPolicy Retain. This created the volumesnapshot and the volumesnapshotcontent object with DeletionPolicy: Retain
  2. Delete the volumesnapshot object created above. Now because the DeletionPolicy was Retain the volumesnapshotcontent object is preserved.
  3. Patch the volumesnapshotcontent object to set its DeletionPolicy to Delete
  4. Now delete the volumesnapshotcontent. At this step, the object's finalizer snapshot.storage.kubernetes.io/volumesnapshotcontent-bound-protection doesn't remove itself and the deletion just sits at the terminal.

What I expected:
I expected that the object to be deleted.

@ashish-amarnath
Copy link
Contributor Author

cc @xing-yang
Is this a valid scenario for the CSI drivers? Is my expectation from the issue correct?

@xing-yang
Copy link
Contributor

@ashish-amarnath Can you test this using the latest code from external-snapshotter? This might be the same issue as reported here: kubernetes-csi/external-snapshotter#292. We are cutting release 2.1.1 soon with this fix so you can wait for that as well.

@ashish-amarnath
Copy link
Contributor Author

Will give that a try. Thanks!

@xing-yang
Copy link
Contributor

@ashish-amarnath, 2.1.1 is released for external-snapshotter.

@ashish-amarnath
Copy link
Contributor Author

This was a false alarm.
/close

@k8s-ci-robot
Copy link
Contributor

@ashish-amarnath: Closing this issue.

In response to this:

This was a false alarm.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants