test driver config #143

pohly · 2020-02-10T12:16:30Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

We want to get rid of hostpath driver specific code in csi-release-tools, both to simplify it and to make it applicable to other CSI drivers.

Which issue(s) this PR fixes:
Related-to kubernetes-csi/csi-release-tools#32

Special notes for your reviewer:

This needs to be rolled out like this:

merge this PR into csi-driver-host-path
do a 1.3.0-rc release
use that release as CSI_PROW_DRIVER_REVISION in prow.sh and update csi-release-tools
merge that change into all repos

Does this PR introduce a user-facing change?:

NONE

Improve README by adding an explicit Kubernetes dependency section

This requires adding one more parallel e2e test run with a special focus flag because snapshot tests are still guarded with a "[Feature:VolumeSnapshotDataSource]" tag. The setting that skips all tests with "[Feature:.*]" has to be removed because it overrides the focus. We don't have serial snapshot tests yet. This needs to be modified again if we add any in the future.

Enable snapshot tests in 1.17 to be run in non-alpha jobs.

Signed-off-by: Grant Griffiths <grant@portworx.com>

…netes_fix Fix version_gt to work with Kubernetes prefix

Update prow hostpath driver version to 1.3.0-rc2

Fix overriding of junit results

Signed-off-by: Grant Griffiths <grant@portworx.com>

…rsion_update Update snapshotter to version v2.0.0

Update hostpath driver version to get fix for connection-timeout

Document the process for releasing a new sidecar

fix incorrect link

This relies on a slightly different deployment script: a "deploy.sh" must exist which knows that it has to dump a test driver configurion into the file pointed to with CSI_PROW_TEST_DRIVER, if that env variable is set. That way, we no longer need to know what capabilities the installed driver has.

pohly · 2020-02-10T13:38:15Z

Testing with the modified prow.sh worked:

It also worked for the external-provisioner, see kubernetes-csi/external-provisioner#403.

I've moved the csi-release-tools changes to kubernetes-csi/csi-release-tools#69.

That this hasn't been done before is an oversight. Apparently it hasn't been a problem because there never have been feature gates that mattered?

pohly · 2020-02-10T13:41:22Z

/assign @msau42

prow.sh: also configure feature gates for kubelet

prow.sh: generic driver installation

msau42

/approve

msau42 · 2020-02-10T17:08:24Z

deploy/kubernetes-1.17/test-driver.yaml

+  Name: hostpath.csi.k8s.io
+  Capabilities:
+    block: true
+    controllerExpansion: true


@gnufied were resizing tests added in 1.16 or 1.17?

According to git diff v1.15.0..v1.16.0 test/e2e/storage/testsuites/testdriver.go, controllerExpansion was added in 1.16:

@@ -126,7 +152,10 @@ const ( // - NodeStageVolume in the spec CapMultiPODs Capability = "multipods" - CapRWX Capability = "RWX" // support ReadWriteMany access modes + CapRWX Capability = "RWX" // support ReadWriteMany access modes + CapControllerExpansion Capability = "controllerExpansion" // support volume expansion for controller + CapNodeExpansion Capability = "nodeExpansion" // support volume expansion for node + CapVolumeLimits = "volumeLimits" // support volume limits (can be *very* slow) )

Shall we enable the tests in 1.16 too then?

What's missing for them in 1.16?

I don't see the capabilities enabled in the 1.16 config

Oh, right. I thought that the change above was for 1.16, but it's 1.17. Let me add it for 1.16 then, too.

Revised test-driver.yaml files:

$ diff deploy/kubernetes-1.15/test-driver.yaml deploy/kubernetes-1.16/test-driver.yaml 2,3c2,3 < # using the Kubernetes 1.15 E2E test suite. For details see: < # https://github.com/kubernetes/kubernetes/tree/v1.15.0/test/e2e/storage/external --- > # using the Kubernetes 1.16 E2E test suite. For details see: > # https://github.com/kubernetes/kubernetes/tree/v1.16.0/test/e2e/storage/external 12a13 > controllerExpansion: true 14d14 < dataSource: true 15a16 > nodeExpansion: true 16a18 > snapshotDataSource: true $ diff deploy/kubernetes-1.16/test-driver.yaml deploy/kubernetes-1.17/test-driver.yaml 2,3c2,3 < # using the Kubernetes 1.16 E2E test suite. For details see: < # https://github.com/kubernetes/kubernetes/tree/v1.16.0/test/e2e/storage/external --- > # using the Kubernetes 1.17 E2E test suite. For details see: > # https://github.com/kubernetes/kubernetes/tree/v1.17.0/test/e2e/storage/external 17a18 > singleNodeVolume: true 18a20 > topology: true

This pulls in the prow.sh which uses the revised deploy script.

This will enable the removal of hostpath specific code from csi-release-tools. The deploy script (now using the name "deploy.sh" because that can be the same for all CSI drivers) is asked to create a test driver configuration in addition to installing the driver. The script could do that dynamically. But in the CSI driver hostpath repo we simply keep one test-driver.yaml per deployment, which works based on the assumption that the E2E test suite that corresponds to the Kubernetes version is used for testing, which is the case nowadays. These three test-driver.yaml are indeed different because the name of capabilities changed over time. prow.sh used to have a union of all those names. Now each file really only uses the name that is applicable. "topology" support hadn't been enabled in prow.sh. This looks like an oversight, so it gets added now.

pohly · 2020-02-11T15:14:12Z

@msau42: I also pulled the corresponding release-tools update into this PR, so the test runs really were done with the new test-driver.yaml files.

msau42 · 2020-02-11T20:23:15Z

/lgtm
/approve

k8s-ci-robot · 2020-02-11T20:23:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

6616a6b5 Merge pull request kubernetes-csi#146 from pohly/kubernetes-1.21 510fb0f9 prow.sh: support Kubernetes 1.21 c63c61b3 prow.sh: add CSI_PROW_DEPLOYMENT_SUFFIX 51ac11c3 Merge pull request kubernetes-csi#144 from pohly/pull-jobs dd54c926 pull-test.sh: test importing csi-release-tools into other repo 7d2643a5 Merge pull request kubernetes-csi#143 from pohly/path-setup 6880b0c8 prow.sh: avoid creating paths unless really running tests bc0504ad Merge pull request kubernetes-csi#140 from jsafrane/remove-unused-k8s-libs 5b1de1ad go-get-kubernetes.sh: remove unused k8s libs 49b42693 Merge pull request kubernetes-csi#120 from pohly/add-kubernetes-release f7e7ee49 docs: steps for adding testing against new Kubernetes release git-subtree-dir: release-tools git-subtree-split: 6616a6b5294b6df39cfce37f4fce7cdce0a77583

msau42 and others added 18 commits December 3, 2019 18:18

Improve README by adding an explicit Kubernetes dependency section

53888ae

Merge pull request kubernetes-csi#52 from msau42/update-readme

9ace020

Improve README by adding an explicit Kubernetes dependency section

Merge pull request kubernetes-csi#56 from msau42/enable-snapshots

9f1f3dd

Enable snapshot tests in 1.17 to be run in non-alpha jobs.

Fix version_gt to work with kubernetes prefix

fc80975

Signed-off-by: Grant Griffiths <grant@portworx.com>

Merge pull request kubernetes-csi#57 from ggriffiths/version_gt_kuber…

f6c74b3

…netes_fix Fix version_gt to work with Kubernetes prefix

Update prow hostpath driver version to 1.3.0-rc2

af9549b

Merge pull request kubernetes-csi#60 from saad-ali/updateHostpathVersion

5f444b8

Update prow hostpath driver version to 1.3.0-rc2

Fix overriding of junit results by using unique names for each e2e run

8b0316c

Merge pull request kubernetes-csi#61 from msau42/enable-snapshots

3c463fb

Fix overriding of junit results

Update snapshotter to version v2.0.0

8191eab

Signed-off-by: Grant Griffiths <grant@portworx.com>

Merge pull request kubernetes-csi#64 from ggriffiths/snapshotter_2_ve…

4cc9174

…rsion_update Update snapshotter to version v2.0.0

Update hostpath driver version to get fix for connection-timeout

6582f2f

Merge pull request kubernetes-csi#65 from msau42/update-hostpath

23be652

Update hostpath driver version to get fix for connection-timeout

Document the process for releasing a new sidecar

ac8a021

Merge pull request kubernetes-csi#54 from msau42/add-release-process

ff3cc3f

Document the process for releasing a new sidecar

fix incorrect link

fa90abd

Merge pull request kubernetes-csi#67 from windayski/fix-link

3c34b4f

fix incorrect link

k8s-ci-robot requested review from msau42 and saad-ali February 10, 2020 12:16

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 10, 2020

pohly mentioned this pull request Feb 10, 2020

WIP Test driver config kubernetes-csi/external-provisioner#403

Closed

pohly mentioned this pull request Feb 10, 2020

prow.sh: generic driver installation kubernetes-csi/csi-release-tools#69

Merged

pohly force-pushed the test-driver-config branch from 4a7987b to 15e3e4c Compare February 10, 2020 13:39

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 10, 2020

prow.sh: also configure feature gates for kubelet

5f74333

That this hasn't been done before is an oversight. Apparently it hasn't been a problem because there never have been feature gates that mattered?

pohly changed the title ~~WIP: test driver config~~ test driver config Feb 10, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2020

k8s-ci-robot assigned msau42 Feb 10, 2020

k8s-ci-robot added 2 commits February 10, 2020 09:01

Merge pull request kubernetes-csi#70 from pohly/kubelet-feature-gates

a1432bc

prow.sh: also configure feature gates for kubelet

Merge pull request kubernetes-csi#69 from pohly/test-driver-config

d717c8c

prow.sh: generic driver installation

msau42 reviewed Feb 10, 2020

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020

pohly added 2 commits February 11, 2020 09:48

release-tools: update to d717c8c

66005a9

This pulls in the prow.sh which uses the revised deploy script.

pohly force-pushed the test-driver-config branch from 15e3e4c to 9abf63f Compare February 11, 2020 08:58

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2020

k8s-ci-robot merged commit 9572e1c into kubernetes-csi:master Feb 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test driver config #143

test driver config #143

pohly commented Feb 10, 2020

pohly commented Feb 10, 2020

pohly commented Feb 10, 2020

msau42 left a comment

msau42 Feb 10, 2020

pohly Feb 10, 2020

msau42 Feb 10, 2020

pohly Feb 10, 2020

msau42 Feb 10, 2020

pohly Feb 10, 2020 •

edited

Loading

pohly Feb 11, 2020

pohly commented Feb 11, 2020

msau42 commented Feb 11, 2020

k8s-ci-robot commented Feb 11, 2020

test driver config #143

test driver config #143

Conversation

pohly commented Feb 10, 2020

pohly commented Feb 10, 2020

pohly commented Feb 10, 2020

msau42 left a comment

Choose a reason for hiding this comment

msau42 Feb 10, 2020

Choose a reason for hiding this comment

pohly Feb 10, 2020

Choose a reason for hiding this comment

msau42 Feb 10, 2020

Choose a reason for hiding this comment

pohly Feb 10, 2020

Choose a reason for hiding this comment

msau42 Feb 10, 2020

Choose a reason for hiding this comment

pohly Feb 10, 2020 • edited Loading

Choose a reason for hiding this comment

pohly Feb 11, 2020

Choose a reason for hiding this comment

pohly commented Feb 11, 2020

msau42 commented Feb 11, 2020

k8s-ci-robot commented Feb 11, 2020

pohly Feb 10, 2020 •

edited

Loading