-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hostpath driver implements the ControllerModityVolume feature #481
Conversation
if err != nil { | ||
return nil, status.Error(codes.NotFound, err.Error()) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @sunnylovestiramisu @msau42
I'm not sure whether mutable parameters should be store in the volume state? It seems useless to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a test parameter here but make it really clear that it is for testing(ModifyVolumeTestingField etc.), also comment out the field so that others do not use it.
/lgtm |
/test pull-kubernetes-csi-csi-driver-host-path-1-27-on-kubernetes-1-27 |
/lgtm @gnufied Do you have an idea of the mock client you used for testing before? |
/assign @msau42 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlory, gnufied, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #479
Special notes for your reviewer:
Does this PR introduce a user-facing change?: