Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify deployments: avoid unnecessary env vars #68

Closed
pohly opened this issue Oct 27, 2018 · 7 comments · Fixed by #515
Closed

simplify deployments: avoid unnecessary env vars #68

pohly opened this issue Oct 27, 2018 · 7 comments · Fixed by #515
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@pohly
Copy link
Collaborator

pohly commented Oct 27, 2018

Setting --csi-address=$(CSI_ADDRESS) is unnecessarily complex. The extra env variable isn't needed.

@pohly
Copy link
Collaborator Author

pohly commented Oct 27, 2018

/assign

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2019
@msau42
Copy link
Collaborator

msau42 commented Apr 27, 2019

/remove-lifecycle stale

I think hostpath deployment still needs some cleanup

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2019
@pohly
Copy link
Collaborator Author

pohly commented Apr 29, 2019

Another enhancement idea: remove stale sockets in a pre-stop lifecycle hook, similar to https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/7295d5ee2dae0c48b7c23f476e5b224700ea1187/deploy/kubernetes/base/node.yaml#L23-L26

I think that can be done in the same PR, therefore I am mentioning it here. We might want to rename this issue to "enhance example deployment" then.

@msau42
Copy link
Collaborator

msau42 commented Jun 7, 2019

/help
/lifecycle frozen

@k8s-ci-robot
Copy link
Contributor

@msau42:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 7, 2019
@pohly
Copy link
Collaborator Author

pohly commented Feb 16, 2022

/unassign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants