-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify deployments: avoid unnecessary env vars #68
Comments
/assign |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale I think hostpath deployment still needs some cleanup |
Another enhancement idea: remove stale sockets in a pre-stop lifecycle hook, similar to https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/7295d5ee2dae0c48b7c23f476e5b224700ea1187/deploy/kubernetes/base/node.yaml#L23-L26 I think that can be done in the same PR, therefore I am mentioning it here. We might want to rename this issue to "enhance example deployment" then. |
/help |
@msau42: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unassign |
Setting
--csi-address=$(CSI_ADDRESS)
is unnecessarily complex. The extra env variable isn't needed.The text was updated successfully, but these errors were encountered: