Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate PV so that the pvSpec is also translated for things like AccessModes etc #163

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Translate PV so that the pvSpec is also translated for things like AccessModes etc #163

merged 1 commit into from
Jul 17, 2019

Conversation

davidz627
Copy link
Contributor

/kind bug
/kind failing-test

Fixes a bug where the pvSpec was not translated and thus didn't pick up the backwards compatibility changes made in the pvSpec when getting AccessModes in particular

/assign @msau42 @ddebroy
/cc @leakingtapan

Fix issue to actually translate backwards compatible access modes for CSI Migration

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Jul 17, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 17, 2019
@msau42
Copy link
Collaborator

msau42 commented Jul 17, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit e4b1060 into kubernetes-csi:master Jul 17, 2019
@davidz627 davidz627 deleted the fix/migrationSpec branch July 17, 2019 00:16
@davidz627
Copy link
Contributor Author

This resolves migration test: [sig-storage] PersistentVolumes Default StorageClass pods that use multiple volumes should be reschedulable [Slow]
https://testgrid.k8s.io/sig-gcp-compute-persistent-disk-csi-driver#Migration%20Kubernetes%20Master%20Driver%20Latest

A new attacher release is not urgent, but is always welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leakingtapan leakingtapan Awaiting requested review from leakingtapan

Assignees

@ddebroy ddebroy

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidz627 @msau42 @k8s-ci-robot @ddebroy