make worker-threads configurable #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
jsafrane
reviewed
Aug 16, 2019
|
And please edit the release note - it's a change that worth having there. |
k8s-ci-robot
added
the
needs-rebase
hoyho
force-pushed
the
feat/worker-config
branch
from
6ad7efe
to
ae1742a
Compare
k8s-ci-robot
added
size/S
msau42
reviewed
Aug 20, 2019
msau42
reviewed
Aug 20, 2019
|
I also updated the wording of the release note. ptal |
hoyho
force-pushed
the
feat/worker-config
branch
from
ae1742a
to
69530e2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hoyho, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently, external-attacher has a hard coded thread count.
However, when user create lot of Pod and PVC currently.
10 thread is not enough to sync VolumeAttachment and PV or it will take
a bit longer time than expected.
Add a configurable flag so that user can configure a suitable value according to their own cluster scale and situation.
Which issue(s) this PR fixes:
Fixes #172
Special notes for your reviewer:
Does this PR introduce a user-facing change?: