2.0 prep: Revert "Revert "Use patch to replace update"" #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7c8996b. Use PATCH instead of UPDATE. It should prevent some version conflict errors. In 2.0 we can change the default RBAC policy and add PATCH there.
Work round our imperfect implemetation of PATCH in fake client / informers. It does not store new version of patched VolumeAttachment to VolumeAttachment informer and thus the controller has to repeat some actions.
k8s-ci-robot
added
release-note-action-required
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
jsafrane
changed the title
Closed
msau42
reviewed
Aug 16, 2019
| @@ -24,7 +24,7 @@ metadata: | |||
| rules: | |||
| - apiGroups: [""] | |||
| resources: ["persistentvolumes"] | |||
| verbs: ["get", "list", "watch", "update"] | |||
| verbs: ["get", "list", "watch", "update", "patch"] | |||
There was a problem hiding this comment.
I'd prefer to have it there, just in case :-)
(btw, I'd prefer if there were just generic "read" and "write" permissions)
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
What this PR does / why we need it:
This PR restores PATCH support in the external attacher. In v2.0 we can change the behavior and also the default RBAC rules that the attacher needs.
Special notes for your reviewer:
The first commit is the same as originally applied by @cwdsuzhou in #149. The second commit openly admits that the fake client / informer is imperfect and enables tests commented out by #149.
I tried to implement the fake PATCH correctly, however, applying
[]bytepatch to existing API object looks impossible.Does this PR introduce a user-facing change?: