Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:VolumePath for Block PV is incorrect #97

Merged
merged 1 commit into from
Nov 1, 2021
Merged

fix:VolumePath for Block PV is incorrect #97

merged 1 commit into from
Nov 1, 2021

Conversation

zhucan
Copy link
Member

@zhucan zhucan commented Oct 22, 2021 •
edited

Signed-off-by: zhucan zhucan.k8s@gmail.com

What type of PR is this?
/kind bug

What this PR does / why we need it:
VolumePath for Block PV is incorrect

Which issue(s) this PR fixes:
Fixes #92

Special notes for your reviewer:
@xing-yang

Does this PR introduce a user-facing change?:

VolumePath for Block PV is incorrect

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 22, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 22, 2021
@zhucan
Copy link
Member Author

zhucan commented Oct 22, 2021

/test

@k8s-ci-robot
Copy link
Contributor

@zhucan: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-kubernetes-csi-external-health-monitor

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhucan
Copy link
Member Author

zhucan commented Oct 22, 2021

/test all

pohly
pohly suggested changes Oct 22, 2021
View reviewed changes
pkg/csi-handler/pv_checker.go Outdated Show resolved Hide resolved
pkg/util/util.go Outdated Show resolved Hide resolved
pkg/agent/framework_test.go Outdated Show resolved Hide resolved
@zhucan
fix:VolumePath for Block PV is incorrect
ddc813b 
Signed-off-by: zhucan <zhucan.k8s@gmail.com>
pohly
pohly approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/agent/framework_test.go
@@ -105,9 +105,13 @@ func runTest(t *testing.T, tc *testCase) {

func mockCSInodeServer(nodeServer *driver.MockNodeServer, objects []*mock.CSIVolume) {
for _, volume := range objects {
volumePath := "/var/lib/kubelet/pods/uid/volumes/kubernetes.io~csi/pv/mount"
if volume.IsBlock {
volumePath = "/var/lib/kubelet/pods/uid/volumeDevices/kubernetes.io~csi/pv"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to myself: when introducing a parameter for configuring /var/lib/kubelet, also update this here.

Ref: kubernetes/kubernetes#92664

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - Volume health monitoring agent is deprecated. We'll remove it once this feature moves to Beta.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2021
@pohly
Copy link
Contributor

pohly commented Oct 25, 2021

/assign @xing-yang for final review and approval.

@xing-yang
Copy link
Contributor

/assign

@xing-yang
Copy link
Contributor

@zhucan Can you add a release note in the PR description section?

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, xing-yang, zhucan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit fd3821a into kubernetes-csi:master Nov 1, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 1, 2021
@zhucan
Copy link
Member Author

zhucan commented Nov 1, 2021

@zhucan Can you add a release note in the PR description section?

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@pohly pohly pohly approved these changes

@humblec humblec Awaiting requested review from humblec

Assignees

@pohly pohly

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VolumePath for Block PV is incorrect
4 participants
@zhucan @k8s-ci-robot @pohly @xing-yang