Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove topology 1.13 fallback logic once 1.13 is unsupported as a node version #257

Closed
msau42 opened this issue Mar 26, 2019 · 5 comments · Fixed by #448
Closed

Remove topology 1.13 fallback logic once 1.13 is unsupported as a node version #257

msau42 opened this issue Mar 26, 2019 · 5 comments · Fixed by #448
Assignees
@msau42
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
2.0

Comments

@msau42
Copy link
Collaborator

msau42 commented Mar 26, 2019

We can do this in 1.16.
/assign
@msau42
Copy link
Collaborator Author

msau42 commented Apr 5, 2019

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 5, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2019
@pohly
Copy link
Contributor

pohly commented Jul 4, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 2, 2019
@msau42
Copy link
Collaborator Author

msau42 commented Oct 3, 2019

/lifecycle frozen
Technically this is a breaking change, let's consider doing this when we need to do a major version bump

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 3, 2019
@msau42 msau42 added this to the 2.0 milestone Dec 24, 2019
@msau42 msau42 mentioned this issue Jun 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msau42 msau42

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Remove topology fallback logic for nodes < 1.14 msau42/external-provisioner
4 participants
@pohly @k8s-ci-robot @msau42 @fejta-bot