New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arg "--enable-leader-election" is not consistent with other sidecars #401

Closed

msau42 opened this issue Feb 4, 2020 · 1 comment · Fixed by #402

Milestone

Collaborator

msau42 commented Feb 4, 2020

All the other sidecars use "--leader-election".

msau42 added this to the 2.0 milestone

Madhu-1 mentioned this issue

Make leader-election flag consistent with other sidecar #402

Merged

Contributor

Madhu-1 commented Feb 5, 2020

@msau42 current default leader election type is Endpoints https://github.com/kubernetes-csi/external-provisioner/blob/master/cmd/csi-provisioner/csi-provisioner.go#L68 to make it consistent with other sidecars are we planning to make default as leases and remove this flag?

msau42 closed this as completed in #402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment