Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme #83

Merged
merged 1 commit into from May 28, 2020
Merged

Update readme #83

merged 1 commit into from May 28, 2020

Conversation

humblec
Copy link
Contributor

@humblec humblec commented May 22, 2020 •
edited

This PR correct the markdown linter errors on the resizer sidecar readme.

Signed-off-by: Humble Chirammal hchiramm@redhat.com

@humblec
Update readme
96c1aa7 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 22, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 22, 2020
@humblec
Copy link
Contributor Author

humblec commented May 22, 2020

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 22, 2020
@humblec
Copy link
Contributor Author

humblec commented May 22, 2020

/assign @msau42

@humblec
Copy link
Contributor Author

humblec commented May 22, 2020

/retest

@gnufied
Copy link
Contributor

gnufied commented May 22, 2020

Can you update the PR description about what we are changing?

@humblec
Copy link
Contributor Author

humblec commented May 22, 2020

Can you update the PR description about what we are changing?

@gnufied done. please check, thanks 👍

@gnufied
Copy link
Contributor

gnufied commented May 22, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2020
@humblec
Copy link
Contributor Author

humblec commented May 28, 2020

@gnufied or @msau42 can you please approve this too ?

@jsafrane
Copy link
Contributor

/approve

1 similar comment
@msau42
Copy link
Collaborator

msau42 commented May 28, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, jsafrane, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0f45f62 into kubernetes-csi:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@gnufied gnufied

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@humblec @gnufied @jsafrane @msau42 @k8s-ci-robot