New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kube vendor dependency and others #286
Conversation
Hi @humblec. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a77b81e
to
6e4914b
Compare
/ok-to-test |
/release-note-none |
@xing-yang @msau42 removing WIP as the CI is passing now. I have changed some function calls too to accomodate params like |
pkg/client/clientset/versioned/typed/volumesnapshot/v1beta1/volumesnapshot.go
Show resolved
Hide resolved
@xing-yang looks we are close to get the CI passing , the last errors what I see atm:
|
@humblec This looks like the files under v2/pkg are not pointing to files directly under pkg. So I suspect that you missed some steps to remove everything before running the script. Can you follow the README and retry? rm -fr v2/
ln -sfvn $(pwd) v2
rm -fr pkg/client |
Sure.. will get on it. Once this is done .. thanks! |
@xing-yang can I go ahead with the rebase here ? |
@humblec Let's wait until we are done with cherry-pick. Thanks. |
@xing-yang sure.. meanwhile I was just trying to rebase and get back to shape :) |
/retest |
@xing-yang will snapshot 2.1.1 includes this PR? will this be part of the next release? if yes when we can expect a release of snapshotter with this change. |
Rebased to master again @xing-yang.
|
@humblec, we don't need node-api, sample-cli-plugin, and sample-controller in go.mod. I could build without them. Please remove them from go.mod. Other than that, it looks good.
|
@xing-yang True, I could build as well, Removed from the patchset. Thanks 👍 |
Can you squash your commits? |
@xing-yang Done. Only 1 commit at current patchset. |
With kubernetes 1.18 release of client-go, signatures on methods in generated clientsets, dynamic, metadata, and scale clients have been modified to accept context.Context as a first argument. Signatures of Create, Update, and Patch methods have been updated to accept CreateOptions, UpdateOptions and PatchOptions respectively. Signatures of Delete and DeleteCollection methods now accept DeleteOptions by value instead of by reference. These changes are now accommodated with this PR and client-go and dependencies are updated to v1.18.0 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: humblec, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xing-yang can you please remove hold label from this PR? |
/hold cancel |
Signed-off-by: Humble Chirammal hchiramm@redhat.com
-->