New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable k8s e2e tests in pull jobs #298
Conversation
@xing-yang @ggriffiths I think there are some problems with the way rbac rules are installed. Can you take a look? |
Yes, taking a look now. |
@msau42 @xing-yang I have two PRs open to fix these tests:
Both fixes are tested together in this PR (with your change from this PR) |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
snapshotter pull jobs were misleading and not actually running the k8s e2e tests.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: