Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable k8s e2e tests in pull jobs #298

Merged
merged 1 commit into from Apr 23, 2020

Conversation

msau42
Copy link
Collaborator

@msau42 msau42 commented Apr 15, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
snapshotter pull jobs were misleading and not actually running the k8s e2e tests.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2020
@msau42
Copy link
Collaborator Author

msau42 commented Apr 15, 2020

@xing-yang @ggriffiths I think there are some problems with the way rbac rules are installed. Can you take a look?

@ggriffiths
Copy link
Member

@xing-yang @ggriffiths I think there are some problems with the way rbac rules are installed. Can you take a look?

Yes, taking a look now.

@ggriffiths
Copy link
Member

@msau42 @xing-yang I have two PRs open to fix these tests:

  1. Fix for RBAC version: Fix csi-snapshotter RBAC yaml version csi-release-tools#78
  2. With the above fix, k8s 1.16 was still failing to deploy the hostpath driver. This fixes that problem:
    Fix deploy-hostpath.sh hostpath pod and CRD conditional for k8s 1.16 csi-driver-host-path#174

Both fixes are tested together in this PR (with your change from this PR)
#299

@msau42
Copy link
Collaborator Author

msau42 commented Apr 23, 2020

/retest

@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit d6aa752 into kubernetes-csi:master Apr 23, 2020
k8s-ci-robot added a commit that referenced this pull request Apr 23, 2020
Cherry pick of #298, #301: Re-enable k8s e2e tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants