New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix requeue logic in the common controller #317
Conversation
cdd0b80
to
815ab01
Compare
/assign @yuxiangqian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuxiangqian Addressed your comments. PTAL. Thanks.
/assign @bswartz |
@yuxiangqian Addressed your comments. PTAL. |
Tested this PR, and it works as well or better than master in my torture tests. |
Thanks @bswartz ! |
@bswartz side topic but is it possible to generalize your stress test and add it to the kubernetes storage e2e test suite? I think we don't do enough stress testing in k8s so this would be a great addition. |
My stress test is just an open-ended loop that creates volume from snapshots and snapshots from volumes, reading and writing data each time. I kick it off and let it run for an arbitrary period of time, sometime 5 minutes, sometimes 5 hours. The pseudocode looks like this: create_empty_volume(0) // creates empty volume 0 After a few hours this loop can run hundreds of times. I was able to shake out some bugs in my CSI drivers using this approach because certain failures only manifested after a dozen or so cycles of create/delete. I'm not sure how this can become an e2e test because of its open-ended nature. There's no obvious place to stop. |
I've added a similar stress test (without snapshots) and made the parallelization and # iterations configurable: |
/cc @AndiLi99 |
@yuxiangqian: GitHub didn't allow me to request PR reviews from the following users: andili99. Note that only kubernetes-csi members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xing-yang lgtm, please squash |
f31fac0
to
5800df6
Compare
@yuxiangqian Squashed commits. PTAL. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xing-yang, yuxiangqian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: