New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-1.1: update release tools #371
release-1.1: update release tools #371
Conversation
Kubernetes also requires 1.12. We pick the latest stable release for CI builds.
update to Go 1.12.4
How a repo does vendoring is detected based on the presence of Gopkg.toml. The vendor check with `dep` was all done locally, but the corresponding check for `go mod` requires network access. The check therefore gets skipped when running in the Prow CI in situations where we are sure that it isn't needed (for example, in a periodic job).
build.make: allow repos to use 'go mod' for vendoring
By moving the code into a separate function, other CSI drivers have a chance to overwrite it. For the hostpath driver itself we need the ability to set the driver name depending on which revision is getting installed.
more flexible test driver config
with specific patch versions that kind 0.4.0 supports. Also, feature gate setting is only supported on 1.15+ due to kind.sigs.k8s.io/v1alpha3 and kubeadm.k8s.io/v1beta2 dependencies.
Add 1.15 jobs
prow.sh: tag master images with a large version number
changes to kind. There are 3 changes made to prow.sh: 1. Use a master commit of kind that includes the fix for Kubernetes master. 2. Use git clone instead of git checkout (shallow) to source Kubernetes. This lets kind correctly figure out the Kubernetes release tag. 3. Build kind with make install. The kind fix was not working correctly when built with go build.
Fix CI jobs on Kubernetes master
Update kind to v0.5.0
Signed-off-by: Deep Debroy <ddebroy@docker.com>
Add rule for building Windows binaries
"make test-vendor" depends on dep if the current project uses dep. Without it, the vendor directory checking was skipped under Prow.
prow.sh: install dep if needed
…h driver Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
…ind-cluster Create 2-node kind cluster since topology support is added to hostpath
build windows binaries with .exe suffix
…ansion Enable hostpath expansion
It turned out that changes like kubernetes-csi/csi-lib-utils#33 should better have been committed after `go mod tidy` because that adds some indirect dependencies in that example. The revised `test-vendor` checks for that and (just in case that this ever becomes desired) allows projects to not have a vendor directory when using `go mod`. How to use `go mod` properly gets documented in the README.md, because there are such pitfalls.
This script handles the necessary "replace" statements and determines which packages need to be updated in lockstep.
Signed-off-by: Deep Debroy <ddebroy@docker.com>
multiarch windows fix
If the Dockerfile needs to run some command, that step fails unless QEMU is set up properly first: failed to solve: rpc error: code = Unknown desc = failed to load LLB: runtime execution on platform linux/ppc64le not supported
cloud build: initialize support for running commands in Dockerfile
As discussed in kubernetes/k8s.io#943, we want to consolidate under k8s-staging-sig-storage.
cloud build: k8s-staging-sig-storage
prow.sh: enable building arm64 image
Signed-off-by: Animesh Kumar <animuz111@gmail.com>
filter-junit: Fix golint error
Signed-off-by: Animesh Kumar <animuz111@gmail.com>
filter-junit: Fix gofmt error
cloud build: bump timeout in Prow job
Add steps on promoting release images
Go 1.15 was released and is the major version that Kubernetes 1.19.0 is going to use. There are probably bugs in the older 1.13.3 that were fixed, so we should update.
switch to Go 1.15
Kubernetes 1.19.0 uses Go 1.15, but refers to it as 1.15.0. This broke both the check whether we need to install 1.15 (because "go version" reports 1.15, which didn't match 1.15.0) and then downloading the release archive (because the URL also only uses 1.15).
It used to be necessary to override from where the E2E suite came on a case-by-case basis (initially, testing was using a more recent suite against an older Kubernetes). This should never become necessary again and the lack of a specific entry for 1.18 already had the unintended effect that Kubernetes 1.18 was tested with the suite from master, so overall it is better to always use the E2E suite which matches Kubernetes.
Kubernetes 1.19 fixes
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ggriffiths The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ggriffiths: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates release tools to latest
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: