Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image name for example webhook, and other nitpicks #378

Merged
merged 1 commit into from Sep 23, 2020

Conversation

bswartz
Copy link
Contributor

@bswartz bswartz commented Sep 22, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The image name for the webhook was wrong in the example.
Also fixed a few nitpicks

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 22, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 22, 2020
Copy link
Collaborator

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the images under external-snapshotter/deploy?
Images should be updated to the following:

k8s.gcr.io/sig-storage/snapshot-controller:v3.0.0
k8s.gcr.io/sig-storage/csi-snapshotter:v3.0.0

deploy/kubernetes/webhook-example/webhook.yaml Outdated Show resolved Hide resolved
@bswartz bswartz force-pushed the webhook-nitpicks branch 2 times, most recently from 240e5f6 to 28ec8ac Compare September 22, 2020 14:44
@xing-yang
Copy link
Collaborator

@msau42
Copy link
Collaborator

msau42 commented Sep 22, 2020

@xing-yang longer term, do you see a way to consolidate all these image examples so we don't have to remember to update all these places every time we cut new releases? I am thinking things like making the image version templatable and using git tags or something to get the latest released version.

Also bump example container versions to v3.0.0, and use
k8s.gcr.io/sig-storage instead of quay.io/k8scsi.
@bswartz
Copy link
Contributor Author

bswartz commented Sep 22, 2020

/retest

@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bswartz, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit e02d45a into kubernetes-csi:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants