New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image name for example webhook, and other nitpicks #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the images under external-snapshotter/deploy?
Images should be updated to the following:
k8s.gcr.io/sig-storage/snapshot-controller:v3.0.0
k8s.gcr.io/sig-storage/csi-snapshotter:v3.0.0
240e5f6
to
28ec8ac
Compare
We should update this one too: https://github.com/kubernetes-csi/external-snapshotter/blob/master/deploy/kubernetes/csi-snapshotter/setup-csi-snapshotter.yaml#L75 We also need to update the hostpath driver when the new image is cut: |
28ec8ac
to
c6ab113
Compare
c6ab113
to
2715d36
Compare
@xing-yang longer term, do you see a way to consolidate all these image examples so we don't have to remember to update all these places every time we cut new releases? I am thinking things like making the image version templatable and using git tags or something to get the latest released version. |
2715d36
to
22ee66d
Compare
Also bump example container versions to v3.0.0, and use k8s.gcr.io/sig-storage instead of quay.io/k8scsi.
22ee66d
to
a2666d1
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bswartz, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The image name for the webhook was wrong in the example.
Also fixed a few nitpicks
Does this PR introduce a user-facing change?: