-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade csi-lib-utils to 0.8.1 #388
Upgrade csi-lib-utils to 0.8.1 #388
Conversation
Hi @Jiawei0227. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
@Jiawei0227 what is the difference between this PR and this other PR that is already merged? #387 |
I see. Looks like #387 is a commit to the master while this one commits to release-3.0. So this one should be a cherry-pick then. |
By the way, this is actually a new feature. We should not be cherry-picking new features into a stable branch. /hold |
This is actually a bug fix. Without this process_start_time metric, we cannot properly extrapolate the beginning part of the histogram data. |
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jiawei0227, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Upgrade csi-lib-utils to version 0.8.1
Special notes for your reviewer:
Does this PR introduce a user-facing change?: