Add webhook to make SourceVolumeMode immutable #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XS
RaunakShah
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
This webhook should have a feature flag as well? |
k8s-ci-robot
added
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
Done! |
RaunakShah
commented
Apr 20, 2022
| @@ -341,8 +341,6 @@ type VolumeSnapshotContentSpec struct { | |||
| // VolumeSnapshotContentSource represents the CSI source of a snapshot. | |||
| // Exactly one of its members must be set. | |||
| // Members in VolumeSnapshotContentSource are immutable. | |||
| // TODO(xiangqian): Add a webhook to ensure that VolumeSnapshotContentSource members | |||
There was a problem hiding this comment.
Not sure why this isn't checked in already. My CI was failing without this change.
There was a problem hiding this comment.
That's very strange. It didn't fail CI when the original PR was merged.
xing-yang
reviewed
Apr 20, 2022
| @@ -67,6 +68,8 @@ func init() { | |||
| CmdWebhook.MarkFlagRequired("tls-private-key-file") | |||
| // Add optional flag for kubeconfig | |||
| CmdWebhook.Flags().StringVar(&kubeconfigFile, "kubeconfig", "", "kubeconfig file to use for volumesnapshotclasses") | |||
| CmdWebhook.Flags().BoolVar(&preventVolumeModeConversion, "prevent-volume-mode-conversion", | |||
| false, "Prevents an unauthorised user from modifying the volume mode when creating a PVC from an existing VolumeSnapshot.") | |||
There was a problem hiding this comment.
Please submit a followup PR to update README.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RaunakShah, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Can you backport this to release-6.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds changes to snapshot-validation-webhook to make the
SourceVolumeModefield immutable.KEP - https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3141-prevent-volume-mode-conversion
Testing
Deploy
snapshot-controllerwith Changes to snapshot controller to add sourceVolumeMode #679Create
VolumeSnapshotobject and attempt to alterSpec.SourceVolumeModefromFilesystemtoBlock. The attempt fails with the below error:Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: