Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-pick] Changes to snapshot controller to add SourceVolumeMode to VolumeSnapshotContents #694

Merged
merged 2 commits into from
Apr 13, 2022
Merged

[Cherry-pick] Changes to snapshot controller to add SourceVolumeMode to VolumeSnapshotContents #694

merged 2 commits into from
Apr 13, 2022

Conversation

RaunakShah
Copy link
Contributor

@RaunakShah RaunakShah commented Apr 13, 2022 •
edited by xing-yang

What type of PR is this?

/kind feature

What this PR does / why we need it:

Cherry pick of #679

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Cherry-pick #679: Changes to snapshot controller to add SourceVolumeMode to VolumeSnapshotContents

@RaunakShah
- Introduce new flag to enable feature to prevent unauthorised volume…
bbcabf0 
… mode conversion

- Changes to snapshot controller to read the volume mode from the PV and add it to SourceVolumeMode field in VolumeSnapshotContent
@RaunakShah
Update code with new type logic
da516a5
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 13, 2022
@RaunakShah RaunakShah changed the title Cp controller sourcemode [Cherry-pick] Changes to snapshot controller to add SourceVolumeMode to VolumeSnapshotContents Apr 13, 2022
@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RaunakShah, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 917d9e7 into kubernetes-csi:release-6.0 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang Awaiting requested review from xing-yang

@yuxiangqian yuxiangqian Awaiting requested review from yuxiangqian

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RaunakShah @xing-yang @k8s-ci-robot