Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change snapshot controller image version to 6.2.1 in release-6.2 branch #811

Closed
wants to merge 2 commits into from

Conversation

Jainbrt
Copy link
Contributor

@Jainbrt Jainbrt commented Feb 22, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Cherrypick #809: Change snapshot controller image version to 6.2.1

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jainbrt
Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 22, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Jainbrt. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 22, 2023
@Jainbrt Jainbrt marked this pull request as ready for review February 22, 2023 10:40
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 22, 2023
@Jainbrt
Copy link
Contributor Author

Jainbrt commented Feb 22, 2023

@xing-yang would you be able to help to get through the trivy scanner failure ?

@Jainbrt
Copy link
Contributor Author

Jainbrt commented Feb 26, 2023

/retest

@k8s-ci-robot
Copy link
Contributor

@Jainbrt: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xing-yang
Copy link
Collaborator

We'll have to submit a PR to resolve the CVEs in order to pass the Trivy scanner. This lib golang.org/x/net needs to be updated to a newer version.

@xing-yang
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2023
@Jainbrt
Copy link
Contributor Author

Jainbrt commented Feb 27, 2023

Thanks @xing-yang for responding. would you suggest to raise a new PR for CVEs?

@xing-yang
Copy link
Collaborator

Thanks @xing-yang for responding. would you suggest to raise a new PR for CVEs?

@Jainbrt Yes, can you help raise a separate PR to fix the CVEs?

@shubhamrajvanshi
Copy link
Contributor

shubhamrajvanshi commented Feb 27, 2023

Thanks @xing-yang for responding. would you suggest to raise a new PR for CVEs?

@Jainbrt Yes, can you help raise a separate PR to fix the CVEs?

Created a PR for this #815.
I hope we can get this PR merged quickly now

@Jainbrt
Copy link
Contributor Author

Jainbrt commented Feb 28, 2023

/retest

@xing-yang
Copy link
Collaborator

You probably need to do a rebase.

@xing-yang
Copy link
Collaborator

Can you squash your commits?

Signed-off-by: Abhishek Jain <abjain39@in.ibm.com>
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 28, 2023
@Jainbrt Jainbrt closed this Feb 28, 2023
@Jainbrt Jainbrt deleted the release-6.2 branch February 28, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants