memory leak on release-0.4

[cospotato]

The livenessprobe will create new grpc connection every request and never close it.

livenessprobe/cmd/main.go

Lines 70 to 73 in 9ef0206

	func getCSIConnection() (connection.CSIConnection, error) {
	// Connect to CSI.
	glog.Infof("Attempting to open a gRPC connection with: %s", *csiAddress)
	csiConn, err := connection.NewConnection(*csiAddress, *connectionTimeout)

[juliohm1978]

Coming by to confirm this is still happening, seems to be affecting the csi-smb-driver as well.

kubernetes-csi/csi-driver-smb#226

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[cospotato]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[cospotato]

/remove-lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[mauriciopoppe]

I see that the connection is closed in https://github.com/kubernetes-csi/livenessprobe/blob/master/cmd/livenessprobe/main.go#L67, is this problem still happening to you?

[cospotato]

I see that the connection is closed in https://github.com/kubernetes-csi/livenessprobe/blob/master/cmd/livenessprobe/main.go#L67, is this problem still happening to you?

Hello @mauriciopoppe . Yes, it was closed in master branch. But i m using Kubernetes 1.11 which need the release-0.4 branch. Would you please pick this fix to the release-0.4 branch ?

[mauriciopoppe]

From https://kubernetes.io/releases/version-skew-policy/

The Kubernetes project maintains release branches for the most recent three minor releases (1.23, 1.22, 1.21). Kubernetes 1.19 and newer receive approximately 1 year of patch support. Kubernetes 1.18 and older received approximately 9 months of patch support.

livenessprobe release-0.4 uses CSI Spec 0.3 which is deprecated as of https://kubernetes-csi.github.io/docs/kubernetes-changelog.html#kubernetes-117 too.

I don't think we can backport given that it's for a version of kubernetes that's no longer supported and by how huge the diff is between the latest version of this library and release-0.4, you could probably fork the library at that release and add the connection close code if this is still a problem.

[cospotato]

you could probably fork the library at that release and add the connection close code if this is still a problem.

@mauriciopoppe OK. Thanks for your reply.