Support contextual logging #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
wg/structured-logging
bells17
force-pushed
the
contextual-logging
branch
2 times, most recently
from
1884439
to
759efd4
Compare
k8s-ci-robot
added
the
do-not-merge/hold
jsafrane
reviewed
May 10, 2024
jsafrane
reviewed
May 13, 2024
Makefile
Outdated
Comment on lines
20
to
24
| # Check contextual logging. | ||
| .PHONY: logcheck | ||
| test: logcheck | ||
| logcheck: | ||
| hack/verify-logcheck.sh |
There was a problem hiding this comment.
Please use the one from release-tools
There was a problem hiding this comment.
@jsafrane Thank you. I changed to use test-logcheck.
bells17
force-pushed
the
contextual-logging
branch
from
759efd4
to
d0ce7e8
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bells17, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
I've updated the klog functions used within livenessprobe to contextual logging functions, following the guidelines below:
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md
In a previous PR below, I addressed structured logging, but I realized that I only handled structured logging and did not address contextual logging.
#202
Therefore, in this PR, I have addressed contextual logging.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
make testormake logcheck)Does this PR introduce a user-facing change?: