Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR makes use of the new csi-lib-utils/rpc package. #39

Merged
merged 2 commits into from Mar 12, 2019

Conversation

@MorrisLaw
Copy link
Contributor

commented Mar 8, 2019

This PR updates livenessprobe to use, the new csi-lib-utils library, rpc.

@k8s-ci-robot k8s-ci-robot requested review from msau42 and sbezverk Mar 8, 2019

@k8s-ci-robot k8s-ci-robot added the size/L label Mar 8, 2019

@MorrisLaw

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

@MorrisLaw MorrisLaw changed the title Consistent sidecars This PR makes use of the new csi-lib-utils/rpc package. Mar 8, 2019

cmd/livenessprobe/main.go Outdated Show resolved Hide resolved
@jsafrane

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

LGTM, please squash the commits.

@MorrisLaw MorrisLaw force-pushed the MorrisLaw:consistent-sidecars branch from 84c3219 to 0d8f500 Mar 8, 2019

@jsafrane

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

/lgtm
/approve

@sbezverk

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, MorrisLaw, sbezverk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b2a6504 into kubernetes-csi:master Mar 12, 2019

2 of 3 checks passed

tide Not mergeable. Needs approved label.
Details
cla/linuxfoundation MorrisLaw authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.