Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing http-endpoint #96

Closed
wants to merge 1 commit into from

Conversation

verult
Copy link
Contributor

@verult verult commented Dec 12, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: Replacement of #95. Replaces metrics-address and health-port flags with http-endpoint.

Special notes for your reviewer: Requires a major version bump.

Does this PR introduce a user-facing change?:

`--metrics-address` and `--health-port` flags are combined into a single flag, `http-endpoint.` The metrics server is also now always enabled.

/assign @Jiawei0227 @msau42

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: verult
To complete the pull request process, please assign msau42 after the PR has been reviewed.
You can assign the PR to them by writing /assign @msau42 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 12, 2020
@verult verult mentioned this pull request Dec 12, 2020
@Jiawei0227
Copy link
Contributor

Can you fix the tests? Otherwise this looks good to me! Thanks

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 14, 2020
@k8s-ci-robot
Copy link
Contributor

@verult: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-livenessprobe-1-19-on-kubernetes-1-19 8bc04a5 link /test pull-kubernetes-csi-livenessprobe-1-19-on-kubernetes-1-19
pull-kubernetes-csi-livenessprobe-1-17-on-kubernetes-1-17 8bc04a5 link /test pull-kubernetes-csi-livenessprobe-1-17-on-kubernetes-1-17
pull-kubernetes-csi-livenessprobe-1-18-on-kubernetes-1-18 8bc04a5 link /test pull-kubernetes-csi-livenessprobe-1-18-on-kubernetes-1-18

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@verult
Copy link
Contributor Author

verult commented Dec 14, 2020

I'm trying to figure out where the liveness probe spec comes from in these presubmits. If it's from here, wondering if there's a way to overwrite flags in the presubmit job.

@verult
Copy link
Contributor Author

verult commented Dec 15, 2020

Unfortunately there's no easy way to overwrite the flag. The options are to (1) keep the old flags and (2) force merge and cut a release right after. (1) is less disruptive. Drafted a new PR with another configuration of old+new flag behavior: #99

@verult verult closed this Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants