Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.6.1 is affected by CVE-2022-32149 #249

Closed
knopt opened this issue Nov 22, 2022 · 7 comments
Closed

v2.6.1 is affected by CVE-2022-32149 #249

knopt opened this issue Nov 22, 2022 · 7 comments
Assignees

Comments

@knopt
Copy link

knopt commented Nov 22, 2022

The latest release is affected by vulnerability CVE-2022-32149 which is marked as high severity. The issue is being addressed in other parts of Kubernetes as well, see: https://github.com/kubernetes/kubernetes/pull/112989/files

My proposed solution is to add the following directive to go.mod:

replace golang.org/x/text => golang.org/x/text v0.4.0

I'd be happy to submit a PR when the solution is agreed upon.

@mauriciopoppe
Copy link
Member

Thanks for raising this issue, we could do that or sync master's go.mod https://github.com/kubernetes-csi/node-driver-registrar/blob/master/go.mod#L42 to release-2.6

@knopt
Copy link
Author

knopt commented Nov 23, 2022

The problem is that the node-driver-registrar master branch has transitive dependencies on golang.org/x/text <v0.3.8. You can see them by running:

$ go mod graph | grep golang.org/x/text
# or
$ cat go.sum | grep golang.org/x/text

replace directive will replace them all. Alternative would be to make every node-driver-registrar dependency to not have any transitive dependencies on affected golang.org/x/text versions which seems unfeasible. Let me know your thoughts.

@mauriciopoppe
Copy link
Member

I see, yes the replace sounds good, you could create a PR against master and then use https://github.com/kubernetes/kubernetes/blob/master/hack/cherry_pick_pull.sh to cherrypick it to release-2.6

@knopt
Copy link
Author

knopt commented Dec 2, 2022

This is fixed by #243

@knopt
Copy link
Author

knopt commented Dec 2, 2022

I've created #255 to cherrypick #243 into 2.6.

@knopt
Copy link
Author

knopt commented Dec 14, 2022

Thank you for merging the MR @msau42 . Is is possible to release 2.6.3 so container without discovered vulns is available?

@mauriciopoppe
Copy link
Member

/assign

@knopt Thanks for the updates in the branches to fix vuln issues.

Yes, I'll create a release for v2.6.2 (for kubernetes 1.25) and also v2.7.0 (new release branch from master for kubernetes 1.26)

@knopt knopt closed this as completed Jan 2, 2023
RaunakShah added a commit to RaunakShah/node-driver-registrar that referenced this issue Feb 23, 2024
dc4d0ae2 Merge pull request kubernetes-csi#249 from jsafrane/use-go-version
e681b170 Use .go-version to get Kubernetes go version

git-subtree-dir: release-tools
git-subtree-split: dc4d0ae20a3dcce17fbfc745fb1f1e3b10cd9644
tyuchn added a commit to tyuchn/node-driver-registrar that referenced this issue Mar 20, 2024
dc4d0ae2 Merge pull request kubernetes-csi#249 from jsafrane/use-go-version
e681b170 Use .go-version to get Kubernetes go version
b54c1ba4 Merge pull request kubernetes-csi#246 from xing-yang/go_1.21
5436c81e Change go version to 1.21.5
267b40e9 Merge pull request kubernetes-csi#244 from carlory/sig-storage
b42e5a2d nominate self (carlory) as kubernetes-csi reviewer
a17f536f Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar
011033de Use set -x instead of die
5deaf667 Add wrapper script for sidecar release
f8c8cc4c Merge pull request kubernetes-csi#237 from msau42/prow
b36b5bfd Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version
adfddcc9 Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix
c4650889 pull-test.sh: avoid "git subtree pull" error
7b175a1e Update csi-test version to v5.2.0
987c90cc Update go version to 1.21 to match k/k
2c625d41 Add script to generate patch release notes
f9d5b9c0 Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version
b01fd537 Bump csi-driver-host-path version up to v1.12.0

git-subtree-dir: release-tools
git-subtree-split: dc4d0ae20a3dcce17fbfc745fb1f1e3b10cd9644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants