Skip to content
This repository has been archived by the owner on Oct 7, 2023. It is now read-only.

Conversation

andrewsykim
Copy link
Contributor

@andrewsykim andrewsykim commented Aug 14, 2017

Adds digitalocean-cloud-controller-manager as an external cloud provider.

01-master.yaml Outdated
@@ -77,6 +78,9 @@ write_files:
- --allow-privileged=true
- --service-cluster-ip-range=${SERVICE_IP_RANGE}
- --secure-port=443
- --storage-backend=etcd2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default storage backend changed in Kubernetes v1.6

01-master.yaml Outdated
--container-runtime=docker \
--allow-privileged=true \
--pod-manifest-path=/etc/kubernetes/manifests \
--hostname-override=$private_ipv4 \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this relied on the hostname being the private IP for apiserver -> kubelet communication. This is no longer required since cloud controller manager will assign proper addresses to nodes. We're also setting --kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname in kube-apiserver

@ghost
Copy link

ghost commented Aug 15, 2017

Hi @andrewsykim, I haven't been working in K8s for a while this year. Do you want to maintain this repository?

@ghost ghost requested review from 5tefan and removed request for 5tefan August 15, 2017 02:24
@ghost
Copy link

ghost commented Aug 15, 2017

I'd even move this repository to its own organization

@ghost ghost requested a review from 5tefan August 15, 2017 02:41
@ghost
Copy link

ghost commented Aug 15, 2017

Done, moved repository, please follow up this issue here

#39

@5tefan
Copy link
Collaborator

5tefan commented Aug 15, 2017

I've been away from k8s for a while too, but looks like it's time to update again!

Hopefully can test this by the weekend. Just from initial glance at digitalocean-cloud-controller-manager, it seems to be in pretty early alpha. In that context, I'm maybe a little cautious about bringing in the dependency? @andrewsykim, you're probably in the best position to comment on the maturity of that.

This would address #21 and #38.

@andrewsykim
Copy link
Contributor Author

@hermanjunge would love to help co-maintain this project.

@5tefan external cloud providers are definitely alpha, I would like to integrate it with this project for early adoption but I understand that there may be people relying on this project to run important workloads.

I can break up this PR, one to upgrade Kubernetes to v1.7 and the other to add the external cloud provider. After you do some testing and provide feedback we can decide what to do about the external cloud provider going forward.

@ghost
Copy link

ghost commented Aug 16, 2017

@andrewsykim Cool. You are owner of this organization, alongside @5tefan. Thank you very much to you both for keeping this work alive.

@5tefan
Copy link
Collaborator

5tefan commented Aug 16, 2017

@hermanjunge Thanks for starting and sharing the project, I hope you can stick around :)

@andrewsykim Understanding this a little better from [1] and [2]. I agree and am leaning towards splitting. Would be easier to isolate any issues. Based on the roadmap in [1], I definitely support early adoption on the cloud-controller-manager. Glad to see DO supporting this! From what I understand, initial addition of the DO cloud-controller-manager should be transparent... after we've made sure of that, we could consider including here a DO LoadBalancer between the microbot pods.

[1] https://github.com/kubernetes/community/blob/master/contributors/design-proposals/cloud-provider-refactoring.md
[2] https://github.com/kubernetes/kubernetes/tree/master/pkg/cloudprovider

@andrewsykim andrewsykim changed the title Upgrade Kubernetes to v1.7.3 and integrate DO Cloud Controller Manager Integrate DO Cloud Controller Manager Aug 31, 2017
@bhcleek
Copy link
Contributor

bhcleek commented Oct 8, 2017

Just need to update the new terraform resource to use https://raw.githubusercontent.com/digitalocean/digitalocean-cloud-controller-manager/master/releases/v0.1.3.yml instead of https://raw.githubusercontent.com/digitalocean/digitalocean-cloud-controller-manager/master/releases/v0.1.0.yml`, and then this + #47 conforms to a configuration that I've successfully tested.

@5tefan 5tefan mentioned this pull request Dec 23, 2017
bhcleek added a commit that referenced this pull request Dec 29, 2017
@bhcleek bhcleek merged commit 3781cfd into kubernetes-digitalocean-terraform:master Dec 29, 2017
kyv pushed a commit to kyv/kubernetes-digitalocean-terraform that referenced this pull request Apr 10, 2018
…kim/digitalocean-cloud-controller-manager
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants