Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot implements rest.GetterWithOptions in custom REST storage #179

Closed
pgayvallet opened this issue Oct 11, 2017 · 4 comments
Closed

Cannot implements rest.GetterWithOptions in custom REST storage #179

pgayvallet opened this issue Oct 11, 2017 · 4 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@pgayvallet
Copy link

Actually, starting the apiserver with a REST resource implementing GetterWithOptions with NewGetOptions returning a type registered in the scheme of the REST resource model will fail with the following error :
error in registering resource: {resourcename}, no kind {GetOptionKind} is registered for version "v1"

This is caused by the fact that when constructing the APIGroupInfo ( in pkg/builders/api_group_builder#Build), the field OptionsExternalVersion is not populated, and therefore set to the default that's defined in k8s.io/apiserver/pkg/server/genericapiserver#NewDefaultAPIGroupInfo : &schema.GroupVersion{Version: "v1"}, which does not contains our {GetOptionKind}

the endpoint installer is then using this default groupversion when trying to resolve the type of get custom get options, resulting in given error.

This is quickly fixed by adding a single line :

i.OptionsExternalVersion = &i.GroupMeta.GroupVersion

after the line

i.GroupMeta.GroupVersion = g.Versions[0].GroupVersion

in pkg/builders/api_group_builder#Build

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 21, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants