New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Kubernetes 1.12 #34
Conversation
This looks pretty reasonable. Just to be double certain, I seem to recall some weird issue when rebasing on 1.12. Everything seems to run fine with this code on your end? |
@DirectXMan12 I've tested these changes with the test adapter and it works fine. |
oh, shoot, I've no idea why I closed this PR. Sorry about that. If you can rebase we can get this merged. |
0ff925d
to
e6c69e7
Compare
e6c69e7
to
d44330b
Compare
No worries. I've just rebased it and tested it works ok with the test adapter. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.