Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

[WIP]should we add releasedTimestamp for pv #1024

Closed
zhangxiaoyu-zidif opened this issue Oct 15, 2018 · 7 comments
Closed

[WIP]should we add releasedTimestamp for pv #1024

zhangxiaoyu-zidif opened this issue Oct 15, 2018 · 7 comments
Labels
area/lib lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@zhangxiaoyu-zidif
Copy link

background:
when we create PV dynamically by storageclass and released those PV. The remained PV should be cleaned periodically.

If we want automatically delete them by released order, we need a release timestamp in PV resource object.

@wongma7
Copy link
Contributor

wongma7 commented Oct 16, 2018

It is the kubernetes PV controller that Releases PVs https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/volume/persistentvolume/pv_controller.go#L801.

To make sure I understand correctly: you want to leave PVs around with Retain reclaim policy and clean them up later with some kind of cron job? Why not give them Delete reclaim policy and let the provisioner delete them?

@zhangxiaoyu-zidif
Copy link
Author

@wongma7 in fact, we want to keep them for re-use, but if those released PVs are not reused for a long time or under disk pressure, we need to delete them by cronjob or other ways.
I need much more considerations.

@zhangxiaoyu-zidif
Copy link
Author

cc @jian-he

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 26, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/lib lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants